apple/t2: init #650
Merged
apple/t2: init #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 14, 2023
apple/t2/default.nix
Outdated
Comment on lines
42
to
45
| powerManagement = { | ||
| powerUpCommands = "${pkgs.kmod}/bin/modprobe apple_touchbar"; | ||
| powerDownCommands = "${pkgs.kmod}/bin/rmmod apple_touchbar"; | ||
| }; |
There was a problem hiding this comment.
It's potentially racy to remove kernel modules this way:
also read here: fed22c2
There was a problem hiding this comment.
What do you think about the changes?
networkException
force-pushed
the
apple-t2-init
branch
from
98eaa5f
to
3d1af7f
Compare
networkException
force-pushed
the
apple-t2-init
branch
from
3d1af7f
to
320de20
Compare
Co-authored-by: networkException <[email protected]>
networkException
force-pushed
the
apple-t2-init
branch
from
320de20
to
8e28b9e
Compare
Mic92
approved these changes
Jul 8, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
networkException
added a commit
to t2linux/wiki
that referenced
this pull request
Jul 10, 2023
I upstreamed their changes in NixOS/nixos-hardware#650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request adds all changes from https://github.com/kekrby/nixos-hardware as well as an update to the most recent kernel and a fix for keyboard backlight not working after suspend, making Apple Intel Macs with the T2 security chip quite usable overall.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input